Add clean.read.parallel support for dirty CSV ingestion#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧾 Pull Request – DataCivicLab
🔗 Issue collegata
Closes #5
🎯 Contesto
Alcuni CSV reali e sporchi non erano leggibili correttamente in CLEAN quando DuckDB richiedeva la disattivazione del parallel scanner per combinazioni come
null_padding=truee righe con quoted new lines.Questa PR introduce un controllo esplicito nel config per gestire quel caso senza workaround esterni.
⚙️ Cosa cambia
clean.read.parallelparallel=true|falsenel reader DuckDB del layer CLEAN📊 Impatto su dati / metodo / dashboard
Indicare se questa PR impatta:
Effetto atteso:
🧪 QA Checklist
Verifiche eseguite:
py -3.14 -m pytest -q -p no:cacheprovider tests/test_clean_duckdb_read.pypy -3.14 -m ruff check --no-cache toolkit/core/csv_read.py toolkit/core/config_models.py toolkit/clean/duckdb_read.py tests/test_clean_duckdb_read.py docs/config-schema.md📝 Note per i reviewer
Punto da verificare: